Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last tag resolved to previous one instead #9

Open
TomasVotruba opened this issue Dec 6, 2020 · 7 comments
Open

Last tag resolved to previous one instead #9

TomasVotruba opened this issue Dec 6, 2020 · 7 comments
Milestone

Comments

@TomasVotruba
Copy link

TomasVotruba commented Dec 6, 2020

Hi,

thank you for the tagging Action. I've been looking for this one for ages.

It works well. We're having small issues on tag release.

We've just released a 0.1.2 here:
https://github.com/symplify/github-actions/runs/1491326330?check_suite_focus=true#step:4:108

But version was resolved to 0.1.1:

image

How can we get the latest tag 0.1.2 insted?


Thank you

@WyriHaximus
Copy link
Owner

Glad you like it! The way this action works is that it uses the Git command to find the latest version. So if the local git inside the active workflow isn't up to date with the latest origin git's tags that could be the cause.

Where can I find the full workflow for this image?

image

@TomasVotruba
Copy link
Author

The git was just pushed with 0.1.2 tag, so it should be there

I've linked the workflow above: https://github.com/symplify/github-actions/runs/1491326330?check_suite_focus=true#step:4:108

@WyriHaximus
Copy link
Owner

Ow ah doh my bad. Was looking for it at the bottom, not at the top. Found that the workflow runs on push, while I was expecting it to run on tag to split the package up on release. Looking at the timestamps, I'm guessing the pulling started just before you tagged the release.

@TomasVotruba
Copy link
Author

Thanks for tips!

The split should happen on both commit and tagging, so tags and dev-master are split.

I've tried to add something in last 3 commits:
https://github.com/symplify/github-actions/commits/master

I've added new tag 0.1.3 here:
https://github.com/symplify/github-actions/runs/1508148735?check_suite_focus=true

Seems it's working :)

Could you give me some feedback on last 3 commits? What to improve there?

@TomasVotruba
Copy link
Author

This is the best approach I came with so far :)

deprecated-packages/github-actions@035b34b

@WyriHaximus WyriHaximus added this to the v1.5.0 milestone Jan 28, 2024
@zliang-akamai
Copy link

This also happened on our repository: https://github.com/linode/linode-cli/actions/runs/11578534127/job/32232579882
I will probably try upgrade to v1.4 to see if it's resolved.

@WyriHaximus
Copy link
Owner

@zliang-akamai The PR @epm-marcus created today might help as well: #56 Looking at it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants