Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tbf-parser #22

Open
george-cosma opened this issue Aug 19, 2024 · 1 comment
Open

Update tbf-parser #22

george-cosma opened this issue Aug 19, 2024 · 1 comment

Comments

@george-cosma
Copy link
Collaborator

The TBF Parsing library is slightly out of date from the original from tock. Updating it immediately is not possible because several additions have been made to the current version so that it works with &[u8] that are not 'static.

In the mean time, only one addition to the spec has been made: types::TbfHeaderTypes::TbfHeaderShortId

Here is the update log: https://github.com/tock/tock/commits/master/libraries/tock-tbf. The current version is probably based on some commit from a year ago.

We have several question to answer:

  1. How should we introduce the TbfHeaderShortId? Should we hand-roll the implementation based on the official implementation?
  2. How do we want to keep up with future updates?
  3. Is it worth upstreaming our changes with no static?
@george-cosma
Copy link
Collaborator Author

To view the differences:

  1. Check out the main branch on this repo. (Make sure everything you have is commited!)
  2. Download this: update.patch
  3. Then git apply update.patch
  4. Then observe the changes yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant