-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add puffin integration #59
Comments
Haven't looked into this yet, but what needs to be done is to figure out which gpu frame should be associated with which cpu frame. That part shouldn't be too hard since wgpu-profiler can be identified by label, see https://github.com/Wumpf/wgpu-profiler/blob/main/src/profiler_query.rs#L9. Labels are ofc tedious and awkward so to make this nicer #54 needs solving, but it would be a start. Not sure if that would need modifications to puffin itself. @emilk without digging too deep does this make sense and do you have an idea how to communicate to puffin that something belongs to an already closed frame? |
Something that I didn't realize is that I could make a separate However, this solution feels pretty ugly, since the WGPU and regular cpu stuff has to be in two separate windows. I'll look into your suggestion. From what I understand, you're suggesting to save the frame number in the label of the scope. Then when I do |
Here's a code review of my current approach using a separate |
It should be possible to have both CPU & GPU traces be shown in sync in Puffin 🤔
(Add an example screenshot of that to readme if it works out!)
The text was updated successfully, but these errors were encountered: