-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Win8 / win10 / modern / metro / uwp apps #198
Comments
I don't have Win8/10 environment now, I will try above solutions when I got one. |
I am wondering whether this feature is under development. If implemented, it would be a huge advantage over Hain (https://github.com/appetizermonster/hain) for example. |
WIP: notes:https://github.com/ljw1004/uwp-desktop http://stackoverflow.com/a/21610315/2833083 AppxPackaginghttp://clrprofiler.codeplex.com/
what have done
problems
todo
|
I have a plugin that does this that is 99% working, without needing to include the .winmd dependency. I'll try to post it to github tonight. |
@talynone that would be great. I'd like to merge your code. |
It's still very raw/unorganized as I just wrote it 2 days ago. It mostly works, I want to refine the icon getting logic more and turn some methods into async/parallels tasks, you can check out what I have so far here: https://github.com/talynone/Wox.Plugin.WindowsUniversalAppLauncher |
I remember |
Well anything can be done alternate ways, but so far it works in resolving the DisplayName properly for all my store applications. I can even remove the dependency on packagemanager by getting the full names via "%LOCALAPPDATA%\Microsoft\Windows\Application Shortcuts" folder and or "HKEY_CURRENT_USER\SOFTWARE\Classes\Local Settings\Software\Microsoft\Windows\CurrentVersion\AppModel\Repository\Packages" registry key. |
There were a few cases where LoadIndirectString wasn't properly extracting the DisplayName/Description, that has been fixed. So for my computer all of them are resolving properly now. Check repository for latest changes. |
@talynone , could you provide a release version of your plugin so we can help testing it. if you have trouble in packaging, you may only offer the dll file and I'll help to pack it. |
@talynone your code truly inspired me to find a better set of APIs. updates to all: |
@happlebao I'm not sure about the things behind your and @talynone 's code, so I have a question. As i said in #857 , I have an app named |
should be |
Did you decide to just catalog "%LOCALAPPDATA%\Microsoft\Windows\Application Shortcuts" folder and parse the .lnk file? |
@jhdxr I know the icon is ugly, but at least it is working... |
Nice! A few things I noticed: You don't have a few fixes I have implemented: Try to search for "calendar" or "mail". In your version "mail" doesn't even show up and "calendar" launches the mail client. In my latest code I enumerate all AppIds that belong to a package with multiple apps defined, then I pass along the AppId at launch time and match against it to make sure it launches the right item in a multi app package. Also there should be no reason to filter against a publisher. Look at my code that rejects a package if the AppListEntry property is set to "none": That way if an app is specified not to show up on the Start Menu, we ignore it and that seems to filter out the nonsense packages. You seem to be also grabbing the wrong icon (I grab the right one 95% of the cases, the spec is actually quite complex on multi app packages) : (Look at my GetBestLogo method). https://msdn.microsoft.com/windows/uwp/controls-and-patterns/tiles-and-notifications-app-assets Also I have preliminary code to generate an icon cache and overlay the current windows accent color as a background color when none/transparent is defined, or a background color specified by the app manifest when it's defined (Check out console tester app) which is what the start menu does. |
Also when testing my plugin on a friend's computer it crashed, apparently she had a semi corrupt store app which caused looking up the "InstalledLocation.Path" property to throw an exception. You'll see in my code I have a try catch to just go to the next package if that happens. |
@happlebao thx, @talynone 's plugin works well with 1.3.231 on my laptop. and the question I asked above, |
@jhdxr how about updated wox? |
e.g. mail and calendar, skype video and messaging #198 (comment)
@talynone @Megasware128 @jhdxr https://ci.appveyor.com/project/happlebao/wox/build/1.3.292/artifacts |
@happlebao mail/calendar works fine now. Thanks. As mentioned before you may want to do the app launch async, so the wox dialog dismisses quickly. Btw my code can deal with mail/calendar just fine, and uses no hacks. Look at my app launch code to see how I deal with it. |
Same for me. Calander and Mail fixed |
close due to no more new issue. |
e.g. mail and calendar, skype video and messaging #198 (comment)
I would like to step in with a quick "manual" fix, as I did not find clear instruction on what to do from the lengthy discussion above.
In case one is curious (as I did myself), here goes what goes into that "shortcut to Windows Store App": something junky, un-editable and un-copy-able. |
Can this become a priority for Wox? I would really like this functionality. |
@Fooughhy |
@Fooughhy |
No description provided.
The text was updated successfully, but these errors were encountered: