Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items deleted from the history cannot be reimported #75

Open
blackforestboi opened this issue Jan 19, 2017 · 2 comments
Open

Items deleted from the history cannot be reimported #75

blackforestboi opened this issue Jan 19, 2017 · 2 comments
Labels

Comments

@blackforestboi
Copy link
Member

blackforestboi commented Jan 19, 2017

When items are deleted from the history list, you can't reimport them.

This is because every imported/visited item gets stored into the local storage under:
localStorage['list_downloaded_urls']

When an import takes place, every URL that is in the history is checked if in that file. If yes, it doesnt get imported.

2. Options to solve this:

  1. We have to update the delete process so that the URL is removed from list_downloaded_urls
  2. Because people might not want to import this by accident again, we just give the notice that these pages have to be proactively revisited and won't ever be importable again.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@NikolayOG
Copy link

Hi, oliver I would like to fix this problem. I am going to implement the second option that you suggested so when user wants to delete URL message will be displayed with option whether he/she wants to delete it or not.

@blackforestboi
Copy link
Member Author

blackforestboi commented Mar 4, 2017

Hello Nikolay!

Thanks for your kind offer to help us out! Very much appreciated!

I don't want you to waste your valuable time. We are currently refactoring the code, so there is no work happening in this repo.
We are in the process to work on the refactor in another project, the WebMemex.

But if you are still up to help us out, you can check out the other repo and raise your hand for one of the newcomer issues: https://github.com/WebMemex/webmemex-extension/issues?q=is%3Aissue+is%3Aopen+label%3Anewcomer-task

Thanks a lot and happy hacking!
May I ask how you stumbled about our project?

Best,
Oliver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants