Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip pages with basic http auth during importing #67

Open
dionysio opened this issue Jan 17, 2017 · 6 comments
Open

Skip pages with basic http auth during importing #67

dionysio opened this issue Jan 17, 2017 · 6 comments

Comments

@dionysio
Copy link

dionysio commented Jan 17, 2017

When you encounter sites requiring basic http authentication during the import the whole process stops and waits. So maybe just skip these pages altogether.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@blackforestboi
Copy link
Member

Thanks @dionysio for your request.

Do you have an idea on how to easily identify them?

@dionysio
Copy link
Author

You could check for 401 Unauthorized status first (and possibly WWW-Authenticate header for basic/digest). Or maybe only accept 20x codes.

@blackforestboi blackforestboi changed the title Feature request: skip pages with basic http auth during importing Skip pages with basic http auth during importing Jan 17, 2017
@blackforestboi
Copy link
Member

I wonder, why they are actually called then, because we already filter out all requests that are !=200

if (xhttp.readyState == 4 && xhttp.status == 200)

@blackforestboi
Copy link
Member

What do you mean with:

Or maybe only accept 20x codes.

@dionysio
Copy link
Author

if (xhttp.readyState == 4 && xhttp.status == 200)

The line you've posted is exactly what I meant - that it should only process responses that have 200 status... so I'm not sure why they actually pass that.

@robert-matusewicz
Copy link

@dionysio @oliversauter it might be that the code drops that 401 and don't process it but browser just shows login window which block further processing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants