-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip pages with basic http auth during importing #67
Comments
Thanks @dionysio for your request. Do you have an idea on how to easily identify them? |
You could check for 401 Unauthorized status first (and possibly WWW-Authenticate header for basic/digest). Or maybe only accept 20x codes. |
I wonder, why they are actually called then, because we already filter out all requests that are !=200 |
What do you mean with:
|
The line you've posted is exactly what I meant - that it should only process responses that have 200 status... so I'm not sure why they actually pass that. |
@dionysio @oliversauter it might be that the code drops that 401 and don't process it but browser just shows login window which block further processing? |
When you encounter sites requiring basic http authentication during the import the whole process stops and waits. So maybe just skip these pages altogether.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: