Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEDX-1780: added format check option #31

Merged
merged 1 commit into from
Oct 17, 2024
Merged

FEDX-1780: added format check option #31

merged 1 commit into from
Oct 17, 2024

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Oct 17, 2024 •
edited by bender-wk
Loading

FEDX-1780

Issue Status

Closes #30

@matthewnitschke-wk matthewnitschke-wk requested a review from a team as a code owner October 17, 2024 15:35
@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

evanweible-wf
evanweible-wf approved these changes Oct 17, 2024
View reviewed changes
Copy link

@evanweible-wf evanweible-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thank you!

@bender-wk bender-wk changed the title added format check option FEDX-1780: added format check option Oct 17, 2024
@matthewnitschke-wk
Copy link
Contributor Author

QA +1

  • CI does indeed pass

🚀 @Workiva/release-management-p 🚢

rmconsole-wf
rmconsole-wf approved these changes Oct 17, 2024
View reviewed changes
Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit 83ee1f8 into master Oct 17, 2024
22 checks passed
@rmconsole-readonly-wk rmconsole-readonly-wk mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmconsole-wf rmconsole-wf rmconsole-wf approved these changes

@evanweible-wf evanweible-wf evanweible-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better support for running workflows in a matrix across multiple SDK versions
5 participants
@matthewnitschke-wk @aviary2-wf @evanweible-wf @rmconsole-wf @rmconsole6-wk