Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transformer also transforms html files in lib #26

Open
kasperpeulen opened this issue Dec 25, 2015 · 3 comments
Open

transformer also transforms html files in lib #26

kasperpeulen opened this issue Dec 25, 2015 · 3 comments

Comments

@kasperpeulen
Copy link
Contributor

The transformer also transforms html files in lib, this can give problems together with angular2 for example. It would be better I think if this would only transform files in web, and also only change the html if there is a match.

it now adds html/body tags to angular templates for example:
@cedx
Copy link

cedx commented Dec 27, 2015

Same problem here: too much work is done by the transformer.

I though that only the script tags would be rewritten but instead the complete markup is transformed for all HTML files in lib and web folders:

  • empty values are added to boolean attributes (async or download becomes async="" or download="")
  • HTML entities are converted to Unicode characters (– becomes -)
  • <html>, <head> and <body> tags are added to HTML fragments (e.g. partial views)

@kasperpeulen
Copy link
Contributor Author

Proposal:

  • Only touch files that have a dart script and are not in lib and leave the others as they are

@kasperpeulen kasperpeulen mentioned this issue Dec 28, 2015
Closed
@koorgoo
Copy link

koorgoo commented Nov 22, 2016

Fixed in e639fc2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kasperpeulen @cedx @koorgoo