Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosubmit verification code when 6 digits are entered. #79

Open
StevenDufresne opened this issue Mar 10, 2023 · 2 comments
Open

Autosubmit verification code when 6 digits are entered. #79

StevenDufresne opened this issue Mar 10, 2023 · 2 comments

Comments

@StevenDufresne
Copy link
Contributor

Right now we require users to click "[Enable]" or hit the enter key to submit their verification code. I don't see a reason why we wouldn't automatically submit it when they have entered 6 digits. It would save them time and since the data is temporary they need not remember it.

Screenshot

Screen Shot 2023-03-10 at 2 22 38 PM

@iandunn
Copy link
Member

iandunn commented Mar 10, 2023

The upstream plugin recently made that change on the login screen. I do have a UX concern, but don't feel strongly. We're already using an XHR in this UI, so it's less of an issue anyway.

@iandunn iandunn added this to the Iteration 1 milestone Mar 10, 2023
@StevenDufresne
Copy link
Contributor Author

a UX concern

Agreed. It should fail silently to not disrupt the user flow experience.

  • Check at 6 digits
    • If it works, provide success confirmation.
    • If it fails, show errors when the user clicks the button, without doing another xhr call.

@StevenDufresne StevenDufresne removed this from the Iteration 2 milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants