-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template column width: adjust center column pages. #134
Comments
I can make that change, but I'm having trouble following all the screenshots above— is that the only change required here? |
Oh, does this need to happen for all pages? |
I think that would be ideal. I don't think we have many pages where we have the 680px column plainly centered. It's always assumed to have either whitespace, or a sidebar (not present on the theme directory) in the area on the right. |
The current Page template has a max-width of 680px, center aligned:
The grid of thumbnails has a max-width of 1160:
Individual theme pages are also 1160:
On pages like Commercial themes, the flow gets disrupted a little bit because both types of layout are present:
The mix of these two causes a bit of a tipping layout. Suggestion: unify on 1160px across, but with a left aligned column for content, that's not quite full-wide. Here's an example from the original directory design:
In that particular image, the left aligned column inside is 680px:
This matches similar designs for Documentation:
Whether it's 680 or something closer to the left-column width of theme permalinks, or even the 800px from the Learn mockups, the important part is that it's a left aligned column inside a container that's 1160px. Learn example:
The text was updated successfully, but these errors were encountered: