Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style local header responsive menu #53

Closed
4 tasks done
iandunn opened this issue Oct 25, 2021 · 1 comment
Closed
4 tasks done

Style local header responsive menu #53

iandunn opened this issue Oct 25, 2021 · 1 comment
Labels
[Type] Enhancement New feature or request
Milestone
Initial Launch: F...

Comments

@iandunn
Copy link
Member

iandunn commented Oct 25, 2021 •
edited
Loading

#41 added the local header, and desktop styles for it. We still need to style the responsive menu though

  • always show "News" link as text, instead of the hamburger menu
  • disable the responsive modal
  • any other visual or behavioral deviations from the mockup

A similar problem is now happening w/ the global footer menu too, though. So, some (or all) of these problems may have started w/ a recent Gutenberg release; particularly WordPress/gutenberg#35568

  • apply all the tasks above to the global footer too
@iandunn iandunn added the [Type] Enhancement New feature or request label Oct 25, 2021
@iandunn iandunn added this to the Initial Launch: Functionality milestone Oct 25, 2021
@iandunn
Copy link
Member Author

iandunn commented Oct 25, 2021

related Automattic/themes#4832

iandunn added a commit to WordPress/wporg-mu-plugins that referenced this issue Oct 26, 2021
@iandunn
Header/Footer: Switch to overlayMenu to restore menu design.
9047308 
`isResponsive` was removed in WordPress/gutenberg#35568, which broke several parts of the design.

See WordPress/wporg-news-2021#53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Enhancement New feature or request
Projects
None yet
Milestone
Initial Launch: Functionality
Development

No branches or pull requests
1 participant
@iandunn