Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vivid Cyan Blue Button Block: Fails Accessible Color Contrast #264

Open
0aveRyan opened this issue Jan 28, 2022 · 6 comments
Open

Vivid Cyan Blue Button Block: Fails Accessible Color Contrast #264

0aveRyan opened this issue Jan 28, 2022 · 6 comments
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Component] Content Issue in the site content, posts, pages, etc

Comments

@0aveRyan
Copy link

Button Blocks with #FFF text and #0693E3 background color (.has-vivid-cyan-blue-background-color) display at 16px in 400 weight, which fails WCAG AA and AAA.
Screenshot 2022-01-28 at 15 05 51

@ryelle ryelle added Accessibility Issues related to keyboard navigation, screen readers, etc [Type] Question Needs input from others before actionable labels Jan 28, 2022
@ryelle
Copy link
Contributor

ryelle commented Jan 28, 2022

hm, this is a content issue, the button is using the core color vivid-cyan-blue on the current site too. I'm tempted to say we should fix the content (update the button color in the editor), but I don't know if there are other places this color is used against white.

I'd like to hear some other thoughts about how we could fix this (because it is a contrast problem).

(labelled question but I really mean "discussion" 🙂 )

@0aveRyan
Copy link
Author

Sorry I was going quick at the end of my day, really should be prefixing these with "the site looks gorgeous, apologies to nitpick" 😇

Everything else I've checked (not comprehensive) passed WCAG AA, this was the only thing that didn't so I just wanted to flag it. I'm not familiar enough with the codebase to know where else it's used.

@ryelle ryelle added [Component] Content Issue in the site content, posts, pages, etc and removed [Type] Question Needs input from others before actionable labels Feb 15, 2022
@dd32
Copy link
Member

dd32 commented Mar 4, 2022

Here are the posts that contain the has-vivid-cyan-blue-background-color class (also the only class in use I could find using 'vivid-cyan' in it's name)

I'm inclined to agree that this is a Content issue.
Making these buttons bold however will also resolve the issue it seems.
I'm not sure simply updating the content will prevent this in future though..

@tellyworth
Copy link
Contributor

#359 makes them bold in css, which should fix it going forward I think.
Screen Shot 2022-03-04 at 3 43 06 pm

@dd32
Copy link
Member

dd32 commented Mar 4, 2022

Is there a plugin available for WordPress/Gutenberg which can flag elements that have low-contrast? That might resolve content issues going forward, and might be able to lean on editors to ensure the elements are accessible?

@ryelle
Copy link
Contributor

ryelle commented Mar 4, 2022

Is there a plugin available for WordPress/Gutenberg which can flag elements that have low-contrast?

That should be a core functionality, but it looks like it's not working on Buttons — made an issue about it here: WordPress/gutenberg#39226

I don't think we should be forcing buttons bold, I would rather see the existing content updated and let the editors manage this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Component] Content Issue in the site content, posts, pages, etc
Projects
None yet
Development

No branches or pull requests

6 participants