-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In meta trac the header nav menu link color is not white. #218
Comments
Hi team, I have checked the cause of this issue. In https://meta.trac.wordpress.org/ site when I inspected the anchor element of navbar link I can see the CSS as shown in below code.
Here there is no color: inherit; CSS. That's why this issue is happening. The CSS of anchor element should be like below code.
Now I inspected the menu.pcss file (path: mu-plugins/blocks/global-header-footer/postcss/header/menu.pcss). Here also I can see the color inherit code and in build file also it is present so I think we need to push the build file again to solve this issue. Because in site color inherit css is not present and in build file and menu.pcss has color inherit css. So by pushing the build file code again this issue will be resolved. |
That sounds related to #213 / #216. It might be that we need to update the header files:
That should only be if the markup changes, but that does include cachebusters. cc @adamwoodnz |
Sorry @iandunn are you saying we need to bump the version here to bust the cache? Is the version just a datetime string? |
I think running the The Trac templates are static/hardcoded since they can't integrate directly with WP. That script will regenerate the templates using the latest data, so that they're synced with the rest of w.org. The updated Trac templates should then have the same cachebusters that are used everywhere else. |
This has been deployed https://meta.trac.wordpress.org/changeset/11990 Let me know if this is fixed for you @Smit2808 and please close if so. |
hi @adamwoodnz and @iandunn, Thank you. Now it's resolved, So closing this ticket. |
In meta trac, the main header nav menu links color is not white like other pages.
Steps to reproduce:
On other pages like: https://make.wordpress.org/meta/. Here you can see the links are clearly visible because it is in white color.
Video link of issue: https://www.loom.com/share/26a313346f3f490f92dd0d8d5d48bbe5
The text was updated successfully, but these errors were encountered: