Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchbox Autocomplete missing. #321

Closed
StevenDufresne opened this issue Nov 2, 2023 · 4 comments · Fixed by #351
Closed

Searchbox Autocomplete missing. #321

StevenDufresne opened this issue Nov 2, 2023 · 4 comments · Fixed by #351
Assignees
Labels
Milestone

Comments

@StevenDufresne
Copy link
Contributor

The autocomplete for searches when using the code reference is not working. It was working when we did a first pass of this design. Was it removed purposefully? That is a very well used feature.

Screenshots

Screenshot 2023-11-02 at 3 55 10 PM

should be:
Screenshot 2023-11-02 at 3 54 28 PM

@StevenDufresne
Copy link
Contributor Author

This was also working on the homepage as well.

@adamwoodnz
Copy link
Contributor

It has not been removed intentionally.

@adamwoodnz adamwoodnz added the [Type] Bug Something isn't working label Nov 6, 2023
@adamwoodnz adamwoodnz added this to the MVP milestone Nov 6, 2023
@renintw renintw self-assigned this Nov 8, 2023
@renintw
Copy link
Contributor

renintw commented Nov 8, 2023

There was originally a search bar on the homepage, right? I remember there used to be one.

However, in the current production version of the code, I’ve noticed that this condition would never evaluates to true on the homepage, resulting in the search bar not being displayed there. Adding is_front_page() would bring it back.

And I initially thought that the search functionality wouldn't work on the current production either, but it turns out that you need to type at least three letters before suggestions pop up.

@adamwoodnz
Copy link
Contributor

There was originally a search bar on the homepage, right? I remember there used to be one.

Not the home page, it's on the reference landing page.

The search has been removed from the new home page, see #309 (comment)

The requirement for this issue is to get it working again on https://developer.wordpress.org/redesign-test/reference/ and the code reference search at https://developer.wordpress.org/redesign-test/?s=block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants