Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ mention should link to any .org users. #33

Closed
bph opened this issue Dec 22, 2022 · 8 comments
Closed

@ mention should link to any .org users. #33

bph opened this issue Dec 22, 2022 · 8 comments
Assignees
Labels
[Component] Backend Anything wp-admin or PHP-related

Comments

@bph
Copy link

bph commented Dec 22, 2022

When using someone's .org username to mention in the props section, the site only seems to pick up people that are users on the site.

It would be helpful if the mention module would pick up any .org username, so we can give props any people giving feedback and reviews on the posts, or on Google Doc.

@ryelle
Copy link
Contributor

ryelle commented Jan 6, 2023

As mentioned, the core behavior is to fetch only current users on the site. We've tweaked the user endpoint before to fetch specific users, but I think there are performance issues with trying to search & fetch lists of wporg users.

@bph
Copy link
Author

bph commented Jan 17, 2023

Thanks @ryelle The PR was merged as a POC but from your comment I deduct that it didn't make it into production? If there is additional work necessary, is there a meta trac issue I can link to and follow? Is it still on the roadmap for future work? I can see that this could also be valuable for other sites and blogs.

This was referenced Feb 2, 2023
@renintw renintw self-assigned this Feb 7, 2023
@renintw
Copy link
Contributor

renintw commented Mar 9, 2023

@bph After some testings, I found that although only for 'users on the site' would a prompt pop up in the editor (renyot in the first img below is a site user, and rentest in the second img is a non-site user), non-site users still have a clickable link after the post is published (thrid img).

I'm wondering if we are looking to have a prompt for non-site users in the editor as well for this issue, or did I miss other content that has props info besides this type?

image image
img 1 - renyot is a site user img 2 - rentest is not a site user but is a .org user
Screen Capture on 2023-03-09 at 21-25-26
img 3 - In a published post, rentest is still a clickable link

@bph
Copy link
Author

bph commented Mar 9, 2023

@renintw Thank you so much for doing further testing. That's good news. If we know it'll be linked on the front end, I think we can live with this. Let's close this issue, too. And I add it to the documentation.

@bph bph closed this as completed Mar 9, 2023
@renintw
Copy link
Contributor

renintw commented Mar 9, 2023

@bph Thanks. It seems like we have closed all the previously mentioned issues that needed to take the Developer Blog out of beta. I guess we could remove "The site is in beta" on the homepage. The remaining issues mostly fall under the scope of the Redesign and may not start in the short term.

@bph
Copy link
Author

bph commented Mar 10, 2023

I agree. @renintw :-)
Next week, I will put together the steps on "Taking out of beta" - Removing the beta section is one, but I also need to update the navigation (content wise ) and find a place for the list of categories to increase discoverability on the front and subsequent pages. Then I will coordinate with marketing team the official launch tasks.

@renintw
Copy link
Contributor

renintw commented Mar 10, 2023

@bph I see. Thanks for the work!

@bph
Copy link
Author

bph commented Mar 10, 2023

Thank YOU for all your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Backend Anything wp-admin or PHP-related
Projects
None yet
Development

No branches or pull requests

3 participants