Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom spacing in core #951

Closed
wants to merge 1 commit into from
Closed

Add support for custom spacing in core #951

wants to merge 1 commit into from

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Jan 28, 2021

See track ticket https://core.trac.wordpress.org/ticket/51760

As per WordPress/gutenberg#25788 the experimental-custom-spacing was marked stable and themes can now add support for it via add_theme_support('custom-spacing'). This PR adds support for it in core.

Test instructions

For this to work, it needs WordPress/gutenberg#28548 to be part of Gutenberg 9.9 and the packages to be released and merged in WordPress core.

When that's done, the instructions below should be reproducible:

  • Install TwentyTwentyOne them, which has support for custom-spacing.
  • Make sure the Gutenberg plugin is not enabled.
  • Go to the post editor and add a group block.
  • Verify that there's a spacing panel:

Captura de ecrã de 2021-01-28 11-50-07

@oandregal
Copy link
Member Author

oandregal commented Jan 28, 2021

I've also prepared the corresponding changes for Gutenberg WordPress/gutenberg#28548

@noisysocks noisysocks closed this Jan 29, 2021
@oandregal oandregal deleted the update/custom-spacing-support branch January 29, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants