Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NPM packages #7996

Closed
wants to merge 10 commits into from
Closed

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Dec 11, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/62220


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj self-assigned this Dec 11, 2024
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ockham
Copy link
Contributor

ockham commented Dec 12, 2024

👋 @desrosj Are you planning to land this in the near future (i.e. well before WP 6.8 Beta 1)?

(FWIW, I'd love that, as I have a janitorial PR that requires a package update 😊)

@desrosj desrosj added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Dec 12, 2024
@desrosj
Copy link
Contributor Author

desrosj commented Dec 12, 2024

@ockham I plan to merge this sometime next week! But it's not a high priority.

Is the concern a merge conflict? Or something else? Don't feel blocked to commit your PR if it's ready and I'll adjust. 😄

@ockham
Copy link
Contributor

ockham commented Dec 12, 2024

@ockham I plan to merge this sometime next week! But it's not a high priority.

Is the concern a merge conflict? Or something else? Don't feel blocked to commit your PR if it's ready and I'll adjust. 😄

Thank you, but I really can't land mine before a package update 😅 A while ago, I removed some now-obsolete functions from the Navigation block's PHP in Gutenberg. My PR moves -- or rather copies -- them to deprecated.php. But that means that they're colliding with the function declarations that still exist in Core's navigation.php -- until that file is updated by a package sync.

I hope that made sense. But again, not urgent at all -- any time before Beta 1 is fine 😄

@desrosj
Copy link
Contributor Author

desrosj commented Dec 13, 2024

@ockham Merged in https://core.trac.wordpress.org/changeset/59509!

There are a few other dependencies with updates that need more work in order to be usable (sinon's update causes test failures, for example). But won't get to those for a bit.

@desrosj desrosj closed this Dec 13, 2024
@desrosj desrosj deleted the update/npm-packages branch December 13, 2024 19:06
@ockham
Copy link
Contributor

ockham commented Dec 13, 2024

Aaand this is where I realize that this PR was about updating 3rd party dependencies, rather than @wordpress/ packages. In my head, I totally equated "Update NPM packages" with "Sync @wordpress/ NPM packages".
Bonus points for me for never actually checking the diff 🤦‍♂️

Anyway. Sorry for the noise. Nothing to see here. Carry on.

Unprops @ockham.

@desrosj
Copy link
Contributor Author

desrosj commented Dec 14, 2024

Sorry! I should have been more specific that it was only devDependencies! No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
props-bot Adding this label triggers the Props Bot workflow for a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants