Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOTP: After successful set up, JS should check the "Enabled" checkbox for the TOTP provider #556

Open
r-a-y opened this issue Apr 26, 2023 · 1 comment · May be fixed by #643
Open

TOTP: After successful set up, JS should check the "Enabled" checkbox for the TOTP provider #556

r-a-y opened this issue Apr 26, 2023 · 1 comment · May be fixed by #643
Assignees
Labels
TOTP Time-based One-time Passwords
Milestone

Comments

@r-a-y
Copy link
Contributor

r-a-y commented Apr 26, 2023

Is your enhancement related to a problem? Please describe.

In two-factor v0.8.0, TOTP was switched over to use the REST API and uses JS to re-render the TOTP options portion of the table on successful TOTP set up. However, after successful TOTP set up, the TOTP provider's "Enabled" checkbox is not checked. This is a usability issue.

Proposed Solution

After successful TOTP set up, the JS should check the "Enabled" checkbox for the TOTP provider in this block:

} ).then( function( response ) {
$( '#two-factor-totp-options' ).html( response.html );
} );
.

Also, I would also like to see a custom jQuery trigger() call so 3rd-party developers can do something after successful TOTP set up or if there is an error with TOTP set up.

Designs

No response

Describe alternatives you've considered

Currently, I'm hooking into jQuery's ajaxComplete event handler to do what I want to do. See r-a-y/bp-two-factor@e7f0da9 .

Please confirm that you have searched existing issues in this repository.

Yes

@dd32 dd32 added Enhancement TOTP Time-based One-time Passwords labels May 25, 2023
@kasparsd kasparsd linked a pull request Sep 19, 2024 that will close this issue
@jeffpaul jeffpaul added this to the 0.10.0 milestone Sep 19, 2024
@kasparsd
Copy link
Collaborator

kasparsd commented Dec 2, 2024

This is fixed in #643.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TOTP Time-based One-time Passwords
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants