Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let theme review action error results prevent theme upload #62

Open
carolinan opened this issue Sep 29, 2021 · 0 comments
Open

Let theme review action error results prevent theme upload #62

carolinan opened this issue Sep 29, 2021 · 0 comments

Comments

@carolinan
Copy link
Contributor

Error results from theme review action does not prevent new themes or theme updates from going live in the theme directory
or from being uploaded.

First, we should determine which errors are a risk or has the most negative consequences and needs to prevent upload.

I propose preventing upload if these two checks returns errors:

  • Page should not have PHP errors
  • Browser console should not contain errors (JavaScript errors)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carolinan