Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block theme specific testing #25

Open
StevenDufresne opened this issue Mar 26, 2021 · 3 comments · Fixed by #26
Open

Block theme specific testing #25

StevenDufresne opened this issue Mar 26, 2021 · 3 comments · Fixed by #26
Labels
enhancement New feature or request

Comments

@StevenDufresne
Copy link
Contributor

StevenDufresne commented Mar 26, 2021

Which block-based theme-specific tests are needed?

Ideas based on documentation: https://github.com/WordPress/gutenberg/tree/trunk/docs/how-to-guides/block-based-theme

  • Validate experimental-theme.json
  • Make sure block-template-part exists if included in block-templates. (It fails quietly)
  • Make sure it doesn't include non-core blocks? (Edit: It can)
@StevenDufresne
Copy link
Contributor Author

Reopening this issue to add more information and test ideas.

@StevenDufresne StevenDufresne added the enhancement New feature or request label Mar 30, 2021
@carolinan
Copy link
Contributor

As I read the list of blockers and flags provided here https://make.wordpress.org/themes/2021/03/17/next-steps-on-themes-and-reviews/ non-core blocks are allowed.

For example, you may want to build a web shop with WooCommerce blocks.
The blocks will error in the editor until the plugin is installed, and should show nothing on the front.

@carolinan
Copy link
Contributor

The tutorial here is very outdated https://github.com/WordPress/gutenberg/tree/trunk/docs/how-to-guides/block-based-theme
The theme.json file can not be validated until it is more stable.
Planned changes: WordPress/gutenberg#29891

I do feel like Gutenberg should provide the validation for this file 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants