Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove theme attribute from template files #171

Closed
jffng opened this issue Jan 19, 2021 · 0 comments
Closed

Remove theme attribute from template files #171

jffng opened this issue Jan 19, 2021 · 0 comments

Comments

@jffng
Copy link
Collaborator

jffng commented Jan 19, 2021 •
edited
Loading

I believe WordPress/gutenberg#28088 makes it so that template files are always assumed to be from the currently active theme. This makes the theme attribute on <!-- wp:template /--> and <!--wp:template-part /--> obsolete, and could become an error depending on how it's resolved.

We should update TT1 Blocks to remove the theme attribute for clarity.
@jffng jffng linked a pull request Jan 19, 2021 that will close this issue
Block Themes: Remove theme attributes from block templates #172
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Block Themes: Remove theme attributes from block templates WordPress/theme-experiments
2 participants
@jffng @carolinan