Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Info message for old way of Custom Header Implementation #152

Closed
ernilambar opened this issue May 6, 2016 · 3 comments
Closed

Info message for old way of Custom Header Implementation #152

ernilambar opened this issue May 6, 2016 · 3 comments

Comments

@ernilambar
Copy link
Member

I have seen some constants being used in some theme. Eg, HEADER_IMAGE_WIDTH, HEADER_IMAGE_HEIGHT. It would be great if we add some INFO message to encourage implementing add_theme_support( 'custom-header' )
@ernilambar
Copy link
Member Author

Following are the define variables which are deprecated.

  • NO_HEADER_TEXT
  • HEADER_IMAGE_WIDTH
  • HEADER_IMAGE_HEIGHT
  • HEADER_TEXTCOLOR
  • HEADER_IMAGE
  • BACKGROUND_COLOR
  • BACKGROUND_IMAGE

@grappler What if we make it required and fail process if such define variables are used in the theme. They are deperecated since long time.

@grappler
Copy link
Member

grappler commented Jun 7, 2016

Yes, I would be fine with that due to this comment in core:

// Constants are lame. Don't reference them. This is just for backwards compatibility.

@ernilambar ernilambar mentioned this issue Jun 8, 2016
Merged
@ernilambar
Copy link
Member Author

Fixed in #162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grappler @ernilambar