Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal errors with "show variables like X" queries #34

Open
xavivars opened this issue Apr 26, 2023 · 2 comments
Open

Fatal errors with "show variables like X" queries #34

xavivars opened this issue Apr 26, 2023 · 2 comments

Comments

@xavivars
Copy link

I'm testing the sqlite-database integration plugin on a production site, where I have (amongs other plugins) Wordfence installed.

While I managed to workaround a previous issue I submitted (see #32 ) by installing a more recent version of SQLite, today I found an issue that doesn't have such an easy workaround.

At some point, Wordfence executes SQL statements like show variables like 'max_allowed_packet' (see https://plugins.trac.wordpress.org/browser/wordfence/trunk/lib/wfDB.php#L146) and the SQLite database integration plugin throws a fatal error, as SQLite doesn't know how to handle such statement.

@aristath
Copy link
Member

aristath commented May 3, 2023

@xavivars Did you test with the stable version from w.org, or the trunk version from this repository?
There have been lots of improvements on trunk which have not yet been released on w.org so maybe this has already been resolved?
I need to do some more testing before releasing the update (mostly related to migrating from the performance-lab to the standalone plugin), but ideally we'd be able to solve this issue as well before releasing an update 👍

@xavivars
Copy link
Author

xavivars commented May 5, 2023

I definitely used the one in the plugin repo, I thought it was in sync with GH.

I can take another look at it with the one from this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants