Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status confusion cycling between Deactivated and Activated #15

Open
OllieJones opened this issue Mar 1, 2023 · 1 comment
Open

Status confusion cycling between Deactivated and Activated #15

OllieJones opened this issue Mar 1, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@OllieJones
Copy link
Contributor

The sqlite-database-integration plugin, standalone, doesn't show activation and deactivation status correctly.

To reproduce:

  1. Activate the plugin.
  2. Look at the Plugins -> drop-ins page (or just the drop-ins count) to ensure wp-content/dp.php is in place.
  3. Look at whether the plugin shows as Activated. Sometimes it wrongly shows as Deactivated.
  4. Activate it again.
  5. Look at whether the plugin shows as Activated. It should show that way.
  6. Deactivate the plugin.
  7. Look at the Plugins -> drop-ins page (or just the drop-ins count) to ensure wp-content/dp.php is gone.
  8. Look at whether the plugin shows as Deactivated. Sometimes it wrongly shows as Activated.
  9. Deactivate it again.
  10. Look at whether the plugin shows as Deactivated. It should show that way.

The root cause of this: most likely the fact that the active_plugins option gets updated in the database that's in play when starting the activation or deactivation workflow, but not in the database that's in play after the workflow.

(This isn't very important in production, but it's confusing when testing things.)

@OllieJones OllieJones added the bug Something isn't working label Mar 1, 2023
@OllieJones
Copy link
Contributor Author

My proposed fix to #16 handles deactivation correctly. Double-activation is still a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant