-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VScode.dev plugin #8
Comments
Actually, there already exists a version of WordPress Playground that fulfills all those criteria. It's the web version. An isomorphic version of wp-now would be really useful here for features like mode detection and wp-cli support. Or two packages like This is also relevant for the browser extension: |
Playground CLI relies mostly on isomorphic APIs these days, perhaps it would be easy enough to adapt for VSCode.dev. |
Agreed, Playground CLI would be easier to use on vscode.dev . I wonder if wp-now should also use Playground CLI. |
That would be great! |
The VS Code extension doesn't work on vscode.dev:
The documentation explains:
The guide lists a number of restrictions. We are affected by at least those:
That's an easy fix – just add
require('vscode')
where it's missing.wp-now
and other packages in this repo use node modules extensively and would have to be refactored. Not sure how involved would that be yet. Technically, there could be a@wp-playground/runtime
module or so that would expose runtime-specific versions of these libraries.The extension calls
worker = new Worker(__dirname + '/worker.js');
. I'm not sure if that's okay.Once
wp-now
supports Blueprints, it will usefetch()
. I'm worried about the CORS part, though. I don't see any blockers for WordPress.org to support it for the downloads we need (WordPress core, plugins, themes), but it may take some time and attention from the systems team.cc @sejas @danielbachhuber @dmsnell @wojtekn
The text was updated successfully, but these errors were encountered: