-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow global and non-persistent groups to be filtered #76
Comments
@JanThiel is taking a go at this. |
Trac Ticket ref: https://core.trac.wordpress.org/ticket/54303 |
WordPress PR (currently still without tests): WordPress/wordpress-develop#2149 |
Just some notes of a discussion Till and I had on the PR. It occurred to me that it might be possible to use a filter for the global groups & require site owners wishing to make use of it to @tillkruss asked some follow up questions, see the following few comments in the thread. |
This is not something we're currently focused on, so I'm going to close this so the any related discussion about this issue can remain in the related Trac ticket: https://core.trac.wordpress.org/ticket/54303 |
See https://core.trac.wordpress.org/ticket/54303 and https://core.trac.wordpress.org/ticket/47884
This is a rarely requested feature, but given the complete lack of flexibility should be addressed.
Core calls
wp_cache_add_global_groups()
very early and usingapply_filters()
is unlikely an option.Adding and removing groups mid-request could be catastrophic, so having an ignore-list may be the best approach:
We should do the exact same for the
wp_cache_add_non_persistent_groups()
call.The text was updated successfully, but these errors were encountered: