Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns: Remove ids from the copied pattern code #698

Open
ryelle opened this issue Jul 4, 2024 · 0 comments
Open

Patterns: Remove ids from the copied pattern code #698

ryelle opened this issue Jul 4, 2024 · 0 comments
Labels
[Component] Pattern Directory The backend of the pattern directory: submission, management, etc [Component] Theme The frontend of the pattern directory, pattern lists UI

Comments

@ryelle
Copy link
Contributor

ryelle commented Jul 4, 2024

See WordPress/gutenberg#60323 — Patterns created outside of the pattern creator have "local" images, with id values matching that other site. When they're used in the pattern directory and then copied, the ID attribute tells the editor that it's not an external image, so you don't get the "upload image" button, even though it's not an image on the destination site.

Can the id attribute be filtered out on copy so that this doesn't happen?

Related: #494
@ryelle ryelle added [Component] Theme The frontend of the pattern directory, pattern lists UI [Component] Pattern Directory The backend of the pattern directory: submission, management, etc labels Jul 4, 2024
This was referenced Jul 4, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Component] Pattern Directory The backend of the pattern directory: submission, management, etc [Component] Theme The frontend of the pattern directory, pattern lists UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryelle