Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Previews: All patterns appear full width, even if they're not full-width #247

Closed
kjellr opened this issue Jun 30, 2021 · 2 comments
Labels
[Type] Enhancement New feature or request

Comments

@kjellr
Copy link
Collaborator

kjellr commented Jun 30, 2021

Describe the bug

All patterns in the directory previews are currently appearing full-width, regardless of their alignment settings. This can be confusing since it's unclear to users which patterns are actually full-width.

For example, all of these appear full-width, but they're actually (from left-to-right) wide, wide, and standard-width:

Screen Shot 2021-06-30 at 11 35 12 AM

At some point earlier, we had the option of specifying a viewportWidth in the editor to help with this, but that doesn't appear possible anymore? Is this something we can adjust somehow?

I'm not sure wether to label this as a bug, since it technically works right now. But I think this could definitely be improved.

@kjellr kjellr added the [Type] Enhancement New feature or request label Jun 30, 2021
@ryelle
Copy link
Contributor

ryelle commented Jul 20, 2021

I think this was due to the previous theme & editor styles that were loaded, and after #266 this has been fixed. @kjellr let me know if you're still seeing the issue.

@ryelle ryelle closed this as completed Jul 20, 2021
@kjellr
Copy link
Collaborator Author

kjellr commented Jul 20, 2021

It appears to be fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants