Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pattern preview: Cover background image is stretched #242

Closed
kjellr opened this issue Jun 29, 2021 · 4 comments
Closed

Pattern preview: Cover background image is stretched #242

kjellr opened this issue Jun 29, 2021 · 4 comments
Labels
[Type] Bug Something isn't working
Milestone
Initial Launch

Comments

@kjellr
Copy link
Collaborator

kjellr commented Jun 29, 2021

When previewing this pattern, the images appear stretched out vertically. This is particularly noticeable on the middle image, which is supposed to be a set of concentric circles.

https://wordpress.org/patterns/pattern/triptych-with-two-images-and-a-text-area/

Pattern Preview Expected
Screen Shot 2021-06-29 at 10 15 13 AM Screen Shot 2021-06-29 at 10 15 05 AM
@kjellr kjellr added the [Type] Bug Something isn't working label Jun 29, 2021
@ryelle
Copy link
Contributor

ryelle commented Jun 29, 2021

What browser & OS are you using? I see it cropped correctly (your expected screenshot) in firefox.

@kjellr
Copy link
Collaborator Author

kjellr commented Jun 29, 2021 •
edited
Loading

Sorry — I should've included that. Looks like it's only happening in Safari (both on iOS 14.6 and MacOS 11.4 with Safari 14.1.1)

@ryelle ryelle added this to the Initial Launch milestone Jul 1, 2021
@coreymckrill
Copy link
Contributor

coreymckrill commented Jul 14, 2021 •
edited
Loading

@kjellr is this still happening for you? I just tried it on MacOS 10.15 with Safari 14.1.1 and I'm seeing the correct crop instead of the stretch. Could be that some other recent change also happened to fix this... (maybe this?)

@ryelle
Copy link
Contributor

ryelle commented Jul 14, 2021

@melchoyce confirmed this is no longer an issue - I bet #266 did fix it, we removed a bunch of unnecessary styles there.

@ryelle ryelle closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
Initial Launch
Development

No branches or pull requests
3 participants
@ryelle @coreymckrill @kjellr