From d695e2954bb13ca0b8227216b9217a555d9be16e Mon Sep 17 00:00:00 2001 From: LuigiPulcini Date: Sat, 18 Aug 2018 20:31:41 -0700 Subject: [PATCH 1/4] MediaPlaceholder multiple property The `gallery` property should be set to `true` only after checking that the selected `type` of media is not `audio`. --- packages/editor/src/components/media-placeholder/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/editor/src/components/media-placeholder/index.js b/packages/editor/src/components/media-placeholder/index.js index f30e68d1cfb6e1..e202458caa747d 100644 --- a/packages/editor/src/components/media-placeholder/index.js +++ b/packages/editor/src/components/media-placeholder/index.js @@ -127,7 +127,7 @@ class MediaPlaceholder extends Component { { __( 'Upload' ) } Date: Thu, 23 Aug 2018 18:48:41 -0700 Subject: [PATCH 2/4] gallery and playlist check for multiple and type gallery and playlist check for multiple and type, being gallery true when multiple is true and type is image, while playlist true when multiple is true and type is audio. --- packages/editor/src/components/media-placeholder/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/editor/src/components/media-placeholder/index.js b/packages/editor/src/components/media-placeholder/index.js index e202458caa747d..78e22aed0a04d1 100644 --- a/packages/editor/src/components/media-placeholder/index.js +++ b/packages/editor/src/components/media-placeholder/index.js @@ -127,7 +127,8 @@ class MediaPlaceholder extends Component { { __( 'Upload' ) } Date: Fri, 24 Aug 2018 02:08:57 -0700 Subject: [PATCH 3/4] type check when setting the gallery property The `gallery` property is set to `true` when `multiple` is `true` and `type === "image"` --- packages/editor/src/components/media-placeholder/index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/editor/src/components/media-placeholder/index.js b/packages/editor/src/components/media-placeholder/index.js index 78e22aed0a04d1..4d72308ef6bff3 100644 --- a/packages/editor/src/components/media-placeholder/index.js +++ b/packages/editor/src/components/media-placeholder/index.js @@ -128,7 +128,6 @@ class MediaPlaceholder extends Component { Date: Fri, 24 Aug 2018 02:51:36 -0700 Subject: [PATCH 4/4] double to single quotes changed type check using single quotes instead of double quotes --- packages/editor/src/components/media-placeholder/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/editor/src/components/media-placeholder/index.js b/packages/editor/src/components/media-placeholder/index.js index 4d72308ef6bff3..b0912c46c91844 100644 --- a/packages/editor/src/components/media-placeholder/index.js +++ b/packages/editor/src/components/media-placeholder/index.js @@ -127,7 +127,7 @@ class MediaPlaceholder extends Component { { __( 'Upload' ) }