Inserter: Should receive focus on open #67754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
jeryj
added
[Type] Bug
jeryj
commented
Dec 9, 2024
Comment on lines
+60
to
+75
| // A test for https://github.com/WordPress/gutenberg/issues/43090. | ||
| await test.step( 'should close the inserter when clicking on the toggle button', async () => { | ||
| const beforeBlocks = await editor.getBlocks(); | ||
|
|
||
| await InserterUtils.openBlockLibrary(); | ||
| await InserterUtils.expectActiveTab( 'Blocks' ); | ||
| await InserterUtils.blockLibrary | ||
| .getByRole( 'option', { name: 'Buttons' } ) | ||
| .click(); | ||
|
|
||
| await expect | ||
| .poll( editor.getBlocks ) | ||
| .toMatchObject( [ ...beforeBlocks, { name: 'core/buttons' } ] ); | ||
|
|
||
| await InserterUtils.closeBlockLibrary(); | ||
| } ); |
There was a problem hiding this comment.
Moving this into a step for better organization and saving a bit of time on e2e test runs.
jeryj
changed the title
|
Size Change: -5 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e33629d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12240299426
|
Mamaduka
reviewed
Dec 9, 2024
| @@ -82,6 +82,8 @@ function InserterMenu( | |||
| if ( isZoomOutMode ) { | |||
| return 'patterns'; | |||
| } | |||
|
|
|||
| return 'blocks'; | |||
There was a problem hiding this comment.
Not sure why we missed this. The getInitialTab should always return value.
There was a problem hiding this comment.
Yeah, I'm surprised we missed it too. I guess we know we're human :)
6 tasks
|
This impacted the "inserter open" metric. That said, it might just because previously we were just rendering nothing right? |
|
@youknowriad That's very odd. Since this impacted the inserter open metric, I'd say there's a different underlying issue this is exposing. It doesn't change what is rendered, just tells the inserter what tab to move focus to when it opens. |
|
Yeah, a 20%+ increase is odd, but then the previous version of |
|
Previously, the Maybe with |
Yes, this is my guess, in which case, there's nothing to revert, but maybe we can try to make the metric independent of the "sync/asynchronous" behavior and count the time until first block is rendered or something. |
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
* Set default tab to 'blocks' if none passed * Add tests for focusing blocks tab and closing inserter on keypresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #67755
What?
We were relying on the tabs component to set an initial tab for us, and then focusing it afterwards. It seems like something has changed within the tabs component's behavior where the selected tab is getting set too late, and our auto-focus check has already completed. Passing which tab we want selected fixes it.
Why?
Consistent behavior and readability. Since we will always have an initial tab selected, it's easier to understand the code if there's always a default tab set instead of having the tabs component guess which one for us.
How?
Sets an initial tab to be focused if none is manually passed.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast