DataViews: Fix filters lost when switching layouts #67740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
requested review from
oandregal,
jameskoster,
jorgefilipecosta and
ntsekouras
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Dec 9, 2024
| isCustom, | ||
| editEntityRecord, | ||
| editedEntityRecord?.id, | ||
| layout, |
There was a problem hiding this comment.
The bug was the presence of "layout" in this hook which caused the "view" to reset even if we didn't want it to.
I refactored the code to use useEvent which means these depenedencies are not needed unless we really want them.
I think it's easier to read now.
|
Size Change: +21 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5c561f0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12236786272
|
|
I've added an e2e test to prevent this regression from happening again. I'll do the same for templates. |
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
What?
When switching layouts in the "pages" (or posts) dataviews, the filters, sorting... is lost. This PR fixes that.
The bug is still present for the moment in the templates dataviews (which I will tackle as well)
Testing Instructions
1- Open the "pages" dataviews
2- Apply some random filter
3- Switch the layout
4- The filter should persist.