Global styles: controls in grid should match between sidebar panel and editor #67602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… global styles panel.
ramonjd
added
[Type] Enhancement
|
Size Change: +9 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Nice one, thank you! I think the only question here is one for @WordPress/gutenberg-components — is this the right way to size up these controls? |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Yes, this is a pretty common way to do it, and we're doing it in a bunch of places already. I actually think it could be declared better at the block editor package level, so one doesn't have to do it again for every panel. |
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
…d editor (#67602) Co-authored-by: ramonjd <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: jasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensure that the single columns in the toolbar grid match the editor's global styles panel.
Why?
They don't match.
How?
Use the same CSS rule.
Testing Instructions
Open the Site Editor > Style > Typography > Text, or any style with typography controls, e.g., paragraph block etc.
Check that the single column blocks span as they do in the editor global styles panel.
Refer to screenshots below.
Screenshots or screencast
Typography > Text
Paragraph block
Global styles panel in editor for reference