Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react native tests to use macos-13 as macos-12 has been deprecated #67586

Closed
wants to merge 1 commit into from

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Dec 4, 2024

See related core-editor slack thread.

What?

As of yesterday, December 3th, macos-12 has been deprecated actions/runner-images#10721 so GitHub Actions won't run. We need to upgrade it.

How?

I've updated it to macos-13 but I'm not experience on reactnative test setup, so I'd welcome reviews from people who are.

Testing Instructions

React Native tests in CI should pass.

@oandregal oandregal requested a review from desrosj as a code owner December 4, 2024 16:36
Copy link

github-actions bot commented Dec 4, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: [Type] Bug, [Type] Build Tooling.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Dec 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: oandregal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@oandregal oandregal self-assigned this Dec 4, 2024
@oandregal oandregal added [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling labels Dec 4, 2024
@oandregal
Copy link
Member Author

cc @WordPress/native-mobile for awareness.

@oandregal oandregal requested a review from dcalhoun December 4, 2024 16:44
@oandregal
Copy link
Member Author

I see there's been movement around this but it's discontinued:

Happy to close this PR for any of those alternatives.

Copy link

github-actions bot commented Dec 4, 2024

Flaky tests detected in 09b5f30.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12164223204
📝 Reported issues:

@oandregal oandregal closed this Dec 9, 2024
@oandregal oandregal deleted the upgrade/react-native-test-macos branch December 9, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant