-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve documentation for fields package #67580
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,10 @@ | ||
export { default as viewPost } from './view-post'; | ||
export { default as reorderPage } from './reorder-page'; | ||
export { default as reorderPageNative } from './reorder-page.native'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dcalhoun sorry to ping you so many times lately :) Is it ok to remove the native actions here? They export There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mostly to make unit tests pass. If nothing breaks, it's ok to remove IMO There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll concede to @youknowriad's knowledge on this one. It appears the addition occurred in 94d1d2b to repair unit test failures. I agree it is safe to remove if unit tests continue passing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the confirmation to both of you 🙇 |
||
export { default as duplicatePost } from './duplicate-post'; | ||
export { default as duplicatePostNative } from './duplicate-post.native'; | ||
export { default as renamePost } from './rename-post'; | ||
export { default as resetPost } from './reset-post'; | ||
export { default as duplicatePattern } from './duplicate-pattern'; | ||
export { default as exportPattern } from './export-pattern'; | ||
export { default as exportPatternNative } from './export-pattern.native'; | ||
export { default as viewPostRevisions } from './view-post-revisions'; | ||
export { default as permanentlyDeletePost } from './permanently-delete-post'; | ||
export { default as restorePost } from './restore-post'; | ||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,4 +27,7 @@ const viewPost: Action< BasePost > = { | |
}, | ||
}; | ||
|
||
/** | ||
* View post action for BasePost. | ||
*/ | ||
export default viewPost; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,9 +14,11 @@ const templateField: Field< BasePost > = { | |
id: 'template', | ||
type: 'text', | ||
label: __( 'Template' ), | ||
getValue: ( { item } ) => item.template, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not necessary. I removed it. #66591 (comment) |
||
Edit: TemplateEdit, | ||
enableSorting: false, | ||
}; | ||
|
||
/** | ||
* Template field for BasePost. | ||
*/ | ||
export default templateField; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +0,0 @@ | ||
export * from './actions/duplicate-post.native'; | ||
export * from './actions/reorder-page.native'; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks! We actually hide this action for templates.