Site Editor: Fix the templates route on mobile #67547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
|
Size Change: -26 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
ramonjd
added a commit
that referenced
this pull request
Dec 4, 2024
…outes/templates.js as they're taken care of in #67547
tellthemachines
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Thanks for the PR, the template editor was totally un-navigable on mobile and this fixes the issue!
I'm still seeing the Uncaught TypeError: navigate is not a function error pop up in the console when clicking around though. Not quite sure what causes it, but I guess it can be looked at in a follow up.
|
Thanks again for testing @tellthemachines !
Yeah, the sidebar components lie outside of the context provider, which contains this function. More info and discussion over here: It doesn't affect functionality for mobile as far as I can tell, but the error isn't encouraging 😄 |
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
Co-authored-by: ramonjd <[email protected]> Co-authored-by: tellthemachines <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: ramonjd <[email protected]> Co-authored-by: tellthemachines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #67467
Similar to #67467, template routes do not work on mobile view
Why?
Fixes a regression.
Testing Instructions
1- Open the site editor on mobile view (narrow width)
2- Click "Templates"
You should see the grid of templates.
Screenshots or screencast
Before
Kapture.2024-12-04.at.11.13.36.mp4
After
Kapture.2024-12-04.at.11.15.09.mp4