-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Block: Fix issue with double-clicking "Create a new menu" causing duplicate menus. #67488
Conversation
…e menus. Co-authored-by: creador-dev <[email protected]>
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @creador-dev! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well for me, thanks for contributing, and congrats on your first Gutenberg code contribution 🎉
const handleButtonClick = () => { | ||
setIsButtonDisabled( true ); | ||
onCreateNew(); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would personally choose to inline this function and as a nicety also pass the arguments through to onCreateNew
, as this changes the type/signature of the prop.
It still works fine though, so these changes aren't strictly needed, I leave it as some thoughtful feedback. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@talldan Thank you so much for your feedback! I really appreciate your insight and will definitely keep this in mind for the future.
…causing duplicate menus. (WordPress#67488) Co-authored-by: creador-dev <[email protected]> Co-authored-by: talldan <[email protected]>
…causing duplicate menus. (#67488) Co-authored-by: creador-dev <[email protected]> Co-authored-by: talldan <[email protected]>
Fixes #56248
What?
This PR addresses an issue where users could accidentally create two navigation menus by double-clicking the "Create a new menu" button in an empty block.
Why?
#56248
How?
The DeletedNavigationWarning component has been updated:
Testing Instructions
Testing Instructions for Keyboard
Interacted Accounts
The following accounts have interacted with this PR and/or linked issues: