Fix: Caption with Link in Wide-Width and Full-Width Images Appears on two lines #67392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Two Lines Instead of One
jorgefilipecosta
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jorgefilipecosta
requested review from
youknowriad,
ntsekouras,
oandregal and
ellatrix
|
Size Change: +6 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Nov 29, 2024
| &.alignfull a, | ||
| &.alignwide a { | ||
| &.alignfull > a, | ||
| &.alignwide > a { |
There was a problem hiding this comment.
Should we do the same for the inline-block style defined above?
There was a problem hiding this comment.
For the inline-block style, #67368 should solve the problem.
youknowriad
approved these changes
Nov 29, 2024
jorgefilipecosta
deleted the
fix/Image-Block-Caption-with-Link-in-Wide-Width-and-Full-Width-Images-Appears-on-Two-Lines-Instead-of-One-Line
branch
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
… two lines (WordPress#67392) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: t-hamano <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
… two lines (#67392) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: t-hamano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if there isa caption with a link, each link takes a full line instead of keeping on the same line.
The issue was caused at #62556.
We want the rule added in the PR above to apply to anchors directly descended of the figure image block container but not to anchors in the caption this PR fixes the issue by changing selectors "&.alignfull a" and "&.alignwide a" to "&.alignfull > a" and "&.alignwide > a" respectively.
Testing Instructions
Add an image block.
Select an image.
Make the block wide aligned.
Add a caption and include a link in the caption.
Verify the caption is still on a single line (on the trunk it is on two lines).