Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Duplicate template part refers to original name instead of duplicated name. #67329

Merged

Conversation

jorgefilipecosta
Copy link
Member

When duplicating a page or pattern the success messages refers to the "new title" (title of the created duplicated object), for template parts the success messages referred the "old title" (title of the original object that was duplicated.

This PR fixes the issue and makes the success message refer the new title as the other duplicate actions do. Making the actions consistent.

Testing

  • Go to wp-admin/site-editor.php?categoryId=header&postType=wp_template_part.
  • Duplicate a header.
  • Verify the success message references the new title.

@jorgefilipecosta jorgefilipecosta added [Type] Bug An existing feature does not function as intended [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Nov 26, 2024
@jorgefilipecosta jorgefilipecosta merged commit 738d5bf into trunk Nov 27, 2024
67 checks passed
@jorgefilipecosta jorgefilipecosta deleted the fix/duplicate-template-part-says-the-old-name branch November 27, 2024 10:24
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Nov 27, 2024
michalczaplinski pushed a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant