DFW: reset zombie state on unmount #67076
Open
+11
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
ellatrix
requested review from
draganescu,
youknowriad,
talldan,
jeryj and
stokesman
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -19 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Nov 18, 2024
packages/editor/src/components/collapsible-block-toolbar/index.js
Outdated
Show resolved
Hide resolved
youknowriad
approved these changes
Nov 18, 2024
ellatrix
commented
Nov 18, 2024
stokesman
reviewed
Nov 18, 2024
Comment on lines
+80
to
+82
| .editor-header__toolbar:has(.editor-collapsible-block-toolbar:not(.is-collapsed)) + .editor-header__center { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
I’d put this in the parent component’s styles instead because this doesn’t apply to any elements of the component itself.
|
Why can't I repro this? no-repro-block-toolbar.mp4 |
It looks like you did repro it. The thing that goes missing is the Document Bar and it’s missing from the start of your recording. I had the same trouble at first—it was unclear what to look for. |
|
OMG thanks @stokesman haha I completely missed out on ... words apparently. |
ellatrix
force-pushed
the
fix/dfw-zombie-state
branch
from
853165c to
ba633ee
Compare
It passes for me too locally 😭 |
|
@jeryj Do you know what could be going on with this test? |
|
@ellatrix The test is checking to see if the fixed toolbar has an overflow scroll to reveal the additional toolbar buttons. On trunk it looks like this: On this PR, the overflow scrolling on the toolbar is broken for some reason. |
jeryj
reviewed
Nov 25, 2024
| } | ||
| }, [ blockSelectionStart, onToggle ] ); |
There was a problem hiding this comment.
Should setIsCollapsed be passed in as a dependency here?
|
I think the issue is related to the CSS for the editor header grid template. In this PR the center element is hidden with display:none instead of being removed from the DOM, so I think some of these grid CSS checks pass now when they did not apply before. |
I thought I tested that manually and found it does work on this branch.
This seems a good point. I think this could cause some other visual issue. I’ve opened up #67322 as an alternative. It’s simpler. In my testing it fixes the issue and doesn’t cause others. Please give it a spin. |
talldan
reviewed
Nov 27, 2024
| useState( true ); | ||
|
|
||
| const hasCenter = | ||
| ( ! hasBlockSelection || isBlockToolsCollapsed ) && |
There was a problem hiding this comment.
Won't removing ! hasBlockSelection bring back the bug in #65824?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Whenever exiting Distraction Free Writing, the document toolbar is gone.
Why?
It should re-appear. This also seems important because Bluesky is using DFW.
How?
Just use CSS to hide the document toolbar.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast