From 38068e4c6e2c68688ce87314e735ec0fac8d930f Mon Sep 17 00:00:00 2001 From: Alex Florisca Date: Fri, 1 Nov 2024 12:40:28 +0000 Subject: [PATCH 1/2] Increase timeout of site-editor selector --- .../e2e-test-utils-playwright/src/admin/visit-site-editor.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts b/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts index f0a7db5ad966ff..4e13a8a5c2f12b 100644 --- a/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts +++ b/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts @@ -54,13 +54,13 @@ export async function visitSiteEditor( // Wait for the canvas loader to appear first, so that the locator that // waits for the hidden state doesn't resolve prematurely. - await canvasLoader.waitFor( { state: 'visible' } ); + await canvasLoader.waitFor( { state: 'visible', timeout: 60000 } ); await canvasLoader.waitFor( { state: 'hidden', // Bigger timeout is needed for larger entities, like the Large Post // HTML fixture that we load for performance tests, which often // doesn't make it under the default timeout value. - timeout: 60_000, + timeout: 60000, } ); } From a5e79cfe3613cd4cceb2445a94cfd76df33a81e4 Mon Sep 17 00:00:00 2001 From: Alex Florisca Date: Tue, 10 Dec 2024 13:05:43 +0000 Subject: [PATCH 2/2] Add the separator back in --- .../e2e-test-utils-playwright/src/admin/visit-site-editor.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts b/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts index 4e13a8a5c2f12b..21bf56b578b57d 100644 --- a/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts +++ b/packages/e2e-test-utils-playwright/src/admin/visit-site-editor.ts @@ -54,13 +54,13 @@ export async function visitSiteEditor( // Wait for the canvas loader to appear first, so that the locator that // waits for the hidden state doesn't resolve prematurely. - await canvasLoader.waitFor( { state: 'visible', timeout: 60000 } ); + await canvasLoader.waitFor( { state: 'visible', timeout: 60_000 } ); await canvasLoader.waitFor( { state: 'hidden', // Bigger timeout is needed for larger entities, like the Large Post // HTML fixture that we load for performance tests, which often // doesn't make it under the default timeout value. - timeout: 60000, + timeout: 60_000, } ); }