From 5b695bbefd281a243a727111e3fae72d88c15828 Mon Sep 17 00:00:00 2001 From: Marco Ciampini Date: Thu, 17 Oct 2024 15:55:39 +0200 Subject: [PATCH 1/3] Tabs: override tablist tabinxed only when necessary --- packages/components/src/tabs/tablist.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/components/src/tabs/tablist.tsx b/packages/components/src/tabs/tablist.tsx index 46cc0488bc67ae..07aac0ecff3039 100644 --- a/packages/components/src/tabs/tablist.tsx +++ b/packages/components/src/tabs/tablist.tsx @@ -111,8 +111,10 @@ export const TabList = forwardRef< ( +
+ ) } onBlur={ onBlur } - tabIndex={ -1 } data-select-on-move={ selectOnMove ? 'true' : 'false' } { ...otherProps } className={ clsx( From 2c1b93185da71ef424e1c0406a44fa89f4814650 Mon Sep 17 00:00:00 2001 From: Marco Ciampini Date: Thu, 17 Oct 2024 16:21:40 +0200 Subject: [PATCH 2/3] Add Comment --- packages/components/src/tabs/tablist.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/components/src/tabs/tablist.tsx b/packages/components/src/tabs/tablist.tsx index 07aac0ecff3039..998da5707aa071 100644 --- a/packages/components/src/tabs/tablist.tsx +++ b/packages/components/src/tabs/tablist.tsx @@ -112,7 +112,12 @@ export const TabList = forwardRef< ref={ refs } store={ store } render={ ( props ) => ( -
+
) } onBlur={ onBlur } data-select-on-move={ selectOnMove ? 'true' : 'false' } From 3300ba146f06e14bc74fdbd79b9869a0a8389a6e Mon Sep 17 00:00:00 2001 From: Marco Ciampini Date: Thu, 17 Oct 2024 16:24:18 +0200 Subject: [PATCH 3/3] CHANGELOG --- packages/components/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 475bf272cc1bb8..53ff933848338c 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -8,6 +8,7 @@ - `ColorPalette`: prevent overflow of custom color button background ([#66152](https://github.com/WordPress/gutenberg/pull/66152)). - `RadioGroup`: Fix arrow key navigation in RTL ([#66202](https://github.com/WordPress/gutenberg/pull/66202)). - `Tabs` and `TabPanel`: Fix arrow key navigation in RTL ([#66201](https://github.com/WordPress/gutenberg/pull/66201)). +- `Tabs`: override tablist's tabindex only when necessary ([#66209](https://github.com/WordPress/gutenberg/pull/66209)). ### Enhancements