Updated code to set active pattern and its styling #66185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +90 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ciampo
added
the
[Status] Duplicate
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
juanfra
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Thank you so much, it's working well to me.
Regarding design and styles, I believe that we need something that indicates the "selected" one more prominently. I see that the "selected" is very subtle and uses a semi-transparent overlay. This means that it won't work on dark color schemes (something that's included in Twenty Twenty-Five). I think it could work if we use the accent color for the border, in addition to the overlay.
Screen.Recording.2024-10-17.at.11.38.49.mov
The other thing I noticed, that's probably unrelated to this work and basically related to the reload, is that the selection is dismissed when you navigate out and then you come back to change the selection. It's probably something that we would want to address at some point. It can be seen in the screencast when I'm going to select the Style and come back to pick the design.
|
Feedback received — I updated the styles in this PR (and suggested an equivalent pack in the original PR).
We got an answer — it looks like we won't improve that particular aspect for now |
|
Flaky tests detected in 76a666e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11407217003
|
|
Fantastic, thank you Marco! |
|
Closing as #65917 was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A few changes applied on top of #65917 to showcase some feedback
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast