Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure popover modals in block editor display above metaboxes #64958

Closed
wants to merge 1 commit into from

Conversation

s-a-s-k-i-a
Copy link

Problem:
When metaboxes are attached to the bottom of the screen in the WordPress block editor, popover modals (e.g., link editing popovers) within the .editor-visual-editor element are incorrectly rendered beneath these metaboxes. This issue makes the popovers partially or fully obscured, leading to usability problems, particularly when editing links within blocks that are located at the bottom of the screen next to possible subsequent metaboxes.

Solution:
Added a z-index: 9; to the .editor-visual-editor CSS rule. This change ensures that the .editor-visual-editor element and its child popovers are displayed above any metaboxes, preventing them from being obscured and maintaining their usability.

Affected Files:

  • Updated the relevant SCSS file(s) to include the z-index property.

This commit resolves the issue where popover modals are not fully visible due to being rendered underneath subsequent containers. #64957

Why?

#64957

Problem:
When metaboxes are attached to the bottom of the screen in the WordPress block editor, popover modals (e.g., link editing popovers) within the `.editor-visual-editor` element are incorrectly rendered beneath these metaboxes. This issue makes the popovers partially or fully obscured, leading to usability problems, particularly when editing links within blocks.

Solution:
Added a `z-index: 9;` to the `.editor-visual-editor` CSS rule. This change ensures that the `.editor-visual-editor` element and its child popovers are displayed above any metaboxes, preventing them from being obscured and maintaining their usability.

Affected Files:
- Updated the relevant SCSS file(s) to include the `z-index` property.

This commit resolves the issue where popover modals are not fully visible due to being rendered underneath subsequent containers. 
WordPress#64957
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: s-a-s-k-i-a <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @s-a-s-k-i-a! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 31, 2024
@t-hamano
Copy link
Contributor

@s-a-s-k-i-a Thanks for the PR!

This problem has been fixed in #63939. This fix will be available in the next minor WordPress release.

I would like to close this PR, but please let me know if there is anything I've missed.

@t-hamano t-hamano closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants