Create Block: Set minimum supported WordPress version to 6.6 #64920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gziolo
added
[Tool] Create Block
|
Size Change: +7 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Aug 30, 2024
| @@ -16,7 +16,7 @@ module.exports = async ( { slug } ) => { | |||
| info( | |||
| 'Installing `@wordpress/scripts` package. It might take a couple of minutes...' | |||
| ); | |||
| await command( 'npm install @wordpress/scripts@27 --save-dev', { | |||
| await command( 'npm install @wordpress/scripts --save-dev', { | |||
|
Flaky tests detected in 987aef3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10629606085
|
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…ss#64920) * Create Block: Set minimum supported WordPress version to 6.6 * Update changelog entries Co-authored-by: gziolo <[email protected]> Co-authored-by: Mamaduka <[email protected]>
|
I see some of these say https://make.wordpress.org/core/handbook/references/php-compatibility-and-wordpress-versions/ |
|
Sure thing @sirreal. I didn’t notice that the min PHP version bumped to 7.2 as of WP 6.6. |
|
I'll create the follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #62234 where the
@wordpress/scriptsversion got pinned to a version supported by WordPress 6.5. Now that WordPress 6.6 is out for a couple of weeks we can finally revert this change.Why?
WordPress 6.6 has all the necessary code to work with the latest version of
@wordpress/scripts.How?
Remove the temorary version enforcment during
@wordpress/scriptsinstallation and set the minimum version for WordPress as 6.6 for all templates.Testing Instructions
Testing Instructions for Keyboard
Run the following locally:
Upload the zip file to the WordPress 6.6 instance, activate the plugin Example Block and ensure it works as expected.
Screenshots or screencast