-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Library: Include a "Select All" options to activate/deactivate all fonts #63531
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2c60c90
Add function to activate all fonts on select all click
akasunil 8acf978
implement toggle to select all fonts
akasunil 5ea589c
add style for select all option
akasunil 3033c2e
Add style for select all lable
akasunil 1c2f346
Removed unneccessory use of flex component
akasunil 23de4fb
Merge branch 'trunk' of personal.github.com:WordPress/gutenberg into …
akasunil e69d25f
Synced with trunk
akasunil 7a1b78e
Remove new function added to context
akasunil ce0b3c1
Modified flow of select all toggle function
akasunil 2c3fa28
Removed extra spaces
akasunil 40bbb4b
Remove use of context
akasunil b0e227d
Update logic to choose all fonts on click in the indeterminate condition
akasunil f3681cb
Fix the issue of select all toggle for fonts without font faces
akasunil c923dff
Remove ad hoc font style for select all label
akasunil 7c3a21b
Updated styles for select all toggle's checkbox to align with other c…
akasunil 8d41f54
Synced with trunk and resolved conflicts
akasunil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To properly align the vertical position of the checkboxes, let's add a 1px border width to the left side.
I've also removed styles that we don't need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!