Query Loop: Change default query loop variations #63353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
mtias,
jasmussen,
richtabor,
ellatrix,
ntsekouras and
priethor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
force-pushed
the
update/change-query-loop-variations
branch
from
41aeff4
to
09764c0
Compare
|
Size Change: -34 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Jul 10, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: priethor <[email protected]>
14 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #30369
What?
A lot of people have raised that the default Query Loop is confusing because picking one of the initial variations results in a query loop that doesn't inherit the default WP query (permalinks, pagination, archive...)
The block itself has "inherit" set to true by default but for some reason (probably unintentional), inherit is set to false when "starting blank" and picking one of the variations.
Note There's another variation that I didn't not update, it's called "Posts List", I think it corresponds more to a "Latest Posts" variation. I believe the original purpose of this variation was to replace the "Latest Posts" widget/block which is also still selectable. I don't think we should update the "inherit" flag for this variation because it will change its purpose entirely but I think we have a few options there:
(This can be addressed separately though)
Testing Instructions
1- Insert Query Loop block
2- Click "Start blank"
3- Pick one of the proposed variations
4- Notice that the inserted query has the "inherit" toggle enabled.