Make edit site pagination buttons accessibly disabled #62267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +24 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/edit-site-pagination-no-truly-disabled
branch
from
59921d2
to
cbfdabc
Compare
mirka
approved these changes
Jun 4, 2024
westonruter
added a commit
that referenced
this pull request
Jun 4, 2024
…dd/on-async-directives * 'trunk' of https://github.com/WordPress/gutenberg: (72 commits) Top toolbar: fix half a pixel artifacting of the bottom border. (#62225) Fix UI order for theme.json spacing sizes (#62199) Chore: Simplify a padding style on global styles. (#62291) Editor: Avoid remounts of `DocumentBar` (#62214) Add `default-spacing-sizes` and `default-font-sizes` options for classic themes (#62252) Editor: Cleanup styles and classnames (#62237) Scripts: Pin the @wordpress/scripts version to a version supported by WP 6.5 (#62234) Documentation: Better changelogs for the JSX transform upgrade (#62265) Chore: Simplify a padding style on dataviews. (#62276) MediaUpload: Remove dialog markup on close (#62168) Tabs: Prevent accidental overflow in indicator (#61979) Make edit site pagination buttons accessibly disabled. (#62267) Fix: Remove unused code from dataviews styles. (#62275) Re-enable React StrictMode (#61943) Inserter: Return the same items when the state and parameters don't change (#62263) Update instances of text-wrap: pretty to fall back to balance (#62233) Update: Slotfill documentation samples (links, code, and rephrase). (#62271) Try: Fix mover positioning. (#62226) [Mobile] - Image corrector - Check the path extension is a valid one (#62190) Update: Block styles documentation. ...
ellatrix
added
the
Backport to WP 6.7 Beta/RC
|
Don't forget the |
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
Co-authored-by: afercia <[email protected]> Co-authored-by: mirka <[email protected]>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
Co-authored-by: afercia <[email protected]> Co-authored-by: mirka <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: afercia <[email protected]> Co-authored-by: mirka <[email protected]>
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #62080
Cc @mirka
What?
Pagination buttons are a typical case where buttons must be still focusable also when 'disabled'.
Looking at the code statically as per the investigation made on #62080, it may appear that they can be 'truly' disabled. However, when using and interacting with these buttons via a keyboard here's the typical scenario where a focus loss must be prevented:
Why?
To prevent focus losses.
How?
Adds the
__experimentalIsFocusableRemoves the eslint disable comment.
Adjusts the style.
Note: the styling of a disabled-focusable button should work consistently with all button variants. For example, the Undo and Redo buttons use
opacitywhile these buttons only use a color change. This should be addressed in the Button component though and there should not be 'local' styling overrides. I'll create a separate issue.Testing Instructions
aria-disabled="true"attribute instead of adisabledone.Testing Instructions for Keyboard
Screenshots or screencast