Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix applying bindings or pattern overrides to button blocks with empty text #62220

Merged
merged 8 commits into from
Jun 10, 2024
Merged

Fix applying bindings or pattern overrides to button blocks with empty text #62220

merged 8 commits into from
Jun 10, 2024

Commits on Jun 10, 2024

  1. Dynamically check button text and avoid rendering a button when empty

    @talldan
    talldan committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ef3f7b3 View commit details
    Browse the repository at this point in the history

  2. Handle both anchor and button tags

    @talldan
    talldan committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    26809e3 View commit details
    Browse the repository at this point in the history

  3. Fix lint issues

    @talldan
    talldan committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a6fddd1 View commit details
    Browse the repository at this point in the history

  4. Address review feedback

    @talldan
    talldan committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    9acd4e6 View commit details
    Browse the repository at this point in the history

  5. Simplify checks for empty content

    @talldan
    talldan committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    08c70ec View commit details
    Browse the repository at this point in the history

  6. Check for comment tokens

    @talldan
    talldan committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f622395 View commit details
    Browse the repository at this point in the history

  7. Update native test snapshots

    @talldan
    talldan committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4ad2cc2 View commit details
    Browse the repository at this point in the history

  8. Update initial HTML native test snippet

    @talldan
    talldan committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    9de03b5 View commit details
    Browse the repository at this point in the history