Lightbox UI block override tests #61414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -37 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
artemiomorales
added
[Type] Automated Testing
gziolo
reviewed
May 6, 2024
|
@gziolo Thanks for the feedback and catching the inconsistencies! I've cleaned up the code and rearranged things in the most recent commit. Let me know what you think. |
|
Flaky tests detected in 87b820b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8983385128
|
gziolo
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
After an initial attempt to reenable the lightbox tests in #60150, this PR aims to break that PR down into smaller chunks so that it is easier to review. It includes two UI tests and removes code for many outdated ones.
To put this PR in context: The UI for the lightbox was recently updated in #57608 with extensive edge cases covered via #59890 (comment). Now that the UX and implementation are a bit more solid, it makes sense to start reenabling test coverage.
How?
It adds a test plugin for handling a first set of theme.json settings and some relevant tests.
Testing Instructions
To run tests locally, use the command
npm run test:e2e -- image.spec.js